Remove relying on "encoding/json" #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This originally depended on "encoding/json" if no options are passed and only depended on "github.com/go-json-experiment/v1" if options are passed. This was a faulty attempt at making it possible to detect divergences in behavior between the two, but it does not work. We may need to add explicit API to detect regressions between "encoding/json" and "github.com/go-json-experiment/json/v1". However, this is complicated by the fact that they will actually be the same package once Go 1.25 is released and the binary is built with GOEXPERIMENT=jsonv2.
mvdan
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originally depended on "encoding/json" if no options are passed and only depended on "github.com/go-json-experiment/v1" if options are passed.
This was a faulty attempt at making it possible to detect divergences in behavior between the two, but it does not work.
We may need to add explicit API to detect regressions between "encoding/json" and "github.com/go-json-experiment/json/v1". However, this is complicated by the fact that they will actually be the same package once Go 1.25 is released and
the binary is built with GOEXPERIMENT=jsonv2.